From b3a6a53dff06ff118bfb113a706de0f68ad0ffd1 Mon Sep 17 00:00:00 2001
From: s j <sj@1729.be>
Date: Thu, 6 Jul 2023 14:35:40 +0200
Subject: [PATCH 1/2] fix: $modules property must be declared protected. See
 https://www.drupal.org/node/2909426

---
 modules/dsr_dashboard/tests/src/Functional/LoadTest.php         | 2 +-
 modules/dsr_deposito/tests/src/Functional/LoadTest.php          | 2 +-
 modules/dsr_deposito/tests/src/Kernel/DepositoTest.php          | 2 +-
 modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php | 2 +-
 modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php      | 2 +-
 modules/dsr_ui/tests/src/Functional/LoadTest.php                | 2 +-
 tests/src/Functional/LoadTest.php                               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/dsr_dashboard/tests/src/Functional/LoadTest.php b/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
index ad73653..3fa2465 100644
--- a/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = ['dsr_dashboard'];
+  protected static $modules = ['dsr_dashboard'];
 
   /**
    * A user with permission to administer site configuration.
diff --git a/modules/dsr_deposito/tests/src/Functional/LoadTest.php b/modules/dsr_deposito/tests/src/Functional/LoadTest.php
index a934397..ec2f8ba 100644
--- a/modules/dsr_deposito/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_deposito/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = ['dsr_deposito'];
+  protected static $modules = ['dsr_deposito'];
 
   /**
    * A user with permission to administer site configuration.
diff --git a/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php b/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
index 93eceb5..2fbb006 100644
--- a/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
+++ b/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
@@ -29,7 +29,7 @@ class DepositoTest extends KernelTestBase {
    *
    * @var array
    */
-  public static $modules = [
+  protected static $modules = [
     'system',
     'user',
     'file',
diff --git a/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php b/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
index b0b48e5..5c3aaa7 100644
--- a/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = ['dsr_gift_certificates'];
+  protected static $modules = ['dsr_gift_certificates'];
 
   /**
    * A user with permission to administer site configuration.
diff --git a/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php b/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
index 27cb0ec..1e7b3b8 100644
--- a/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = [
+  protected static $modules = [
     'webform',
     'dsr_sign_up_form',
   ];
diff --git a/modules/dsr_ui/tests/src/Functional/LoadTest.php b/modules/dsr_ui/tests/src/Functional/LoadTest.php
index 3200fef..03d38ef 100644
--- a/modules/dsr_ui/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_ui/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = ['dsr_ui'];
+  protected static $modules = ['dsr_ui'];
 
   /**
    * A user with permission to administer site configuration.
diff --git a/tests/src/Functional/LoadTest.php b/tests/src/Functional/LoadTest.php
index 1e670ae..8af51de 100644
--- a/tests/src/Functional/LoadTest.php
+++ b/tests/src/Functional/LoadTest.php
@@ -24,7 +24,7 @@ class LoadTest extends BrowserTestBase {
    *
    * @var array
    */
-  public static $modules = ['dsr'];
+  protected static $modules = ['dsr'];
 
   /**
    * A user with permission to administer site configuration.
-- 
GitLab


From c6f5c62405b440a7fb337ab6d637a6dcd08d0875 Mon Sep 17 00:00:00 2001
From: s j <sj@1729.be>
Date: Thu, 6 Jul 2023 14:37:30 +0200
Subject: [PATCH 2/2] fix: Declaring ::setUp without a void return typehint is
 deprecated in drupal:9.0.0.

---
 modules/dsr_dashboard/tests/src/Functional/LoadTest.php         | 2 +-
 modules/dsr_deposito/tests/src/Functional/LoadTest.php          | 2 +-
 modules/dsr_deposito/tests/src/Kernel/DepositoTest.php          | 2 +-
 modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php | 2 +-
 modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php      | 2 +-
 modules/dsr_ui/tests/src/Functional/LoadTest.php                | 2 +-
 tests/src/Functional/LoadTest.php                               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/dsr_dashboard/tests/src/Functional/LoadTest.php b/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
index 3fa2465..e611eed 100644
--- a/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_dashboard/tests/src/Functional/LoadTest.php
@@ -36,7 +36,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
diff --git a/modules/dsr_deposito/tests/src/Functional/LoadTest.php b/modules/dsr_deposito/tests/src/Functional/LoadTest.php
index ec2f8ba..7225453 100644
--- a/modules/dsr_deposito/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_deposito/tests/src/Functional/LoadTest.php
@@ -36,7 +36,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
diff --git a/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php b/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
index 2fbb006..fc52dfc 100644
--- a/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
+++ b/modules/dsr_deposito/tests/src/Kernel/DepositoTest.php
@@ -55,7 +55,7 @@ class DepositoTest extends KernelTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->traitSetUp();
     $this->installEntitySchema('accounting_account');
diff --git a/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php b/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
index 5c3aaa7..d6dc92e 100644
--- a/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_gift_certificates/tests/src/Functional/LoadTest.php
@@ -36,7 +36,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
diff --git a/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php b/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
index 1e7b3b8..d8972c3 100644
--- a/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_sign_up_form/tests/src/Functional/LoadTest.php
@@ -39,7 +39,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
diff --git a/modules/dsr_ui/tests/src/Functional/LoadTest.php b/modules/dsr_ui/tests/src/Functional/LoadTest.php
index 03d38ef..456cea2 100644
--- a/modules/dsr_ui/tests/src/Functional/LoadTest.php
+++ b/modules/dsr_ui/tests/src/Functional/LoadTest.php
@@ -36,7 +36,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
diff --git a/tests/src/Functional/LoadTest.php b/tests/src/Functional/LoadTest.php
index 8af51de..ab0e5bc 100644
--- a/tests/src/Functional/LoadTest.php
+++ b/tests/src/Functional/LoadTest.php
@@ -36,7 +36,7 @@ class LoadTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
-- 
GitLab